This repository has been archived by the owner on Feb 17, 2022. It is now read-only.
Go 1.13 support #26
Merged
Go 1.13 support #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.13 doesn't like the temporary directories, and they were always quite the hack anyway. Rework it so it simply loads the compiled dynamic objects. This is a backwards incompatible change, because the plugin must now be a main package rather than anything else. But I don't think there's any other easy way to support plugins on 1.13 so I will go for this. It's more evidence that the next release should probably be called 2.0 regardless of its size.
Probably we should just drop non-module support instead. If the next release is 2.0 then I will do that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out #25 didn't need any fix, because the default behavior was reverted in golang/go#31857.
But plugins didn't work on go 1.13. Now we use the previously unused go module path, directly compiling the plugin directory. That requires it to be
package mainwhich means it's yet another backwards incompatible change. Might need to do a 2.0 release soon now.