Add Object::Response to Net::SAML2 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterkip
force-pushed
the
GH-209-response_object_for_responses
branch
6 times, most recently
from
8b4aa7d
to
284c28a
Compare
This attribute is needed in more than one type, so let's implement it. Consumers may need to add the required bit. In addition also add the success() method (although I think we need to call it is_success). Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
waterkip
force-pushed
the
GH-209-response_object_for_responses
branch
from
284c28a
to
4f4be26
Compare
This is to accomodate responses which do not include Assertions Closes: perl-net-saml2#209 Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
waterkip
force-pushed
the
GH-209-response_object_for_responses
branch
from
4f4be26
to
ecee0e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to accomodate responses which do not include Assertions