Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set key to be only for signing by adding signing_only in the SP #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set key to be only for signing by adding signing_only in the SP #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/Net/SAML2/SP.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,11 @@ Path to the private key for the signing certificate
Path to the public key that the IdP should use for encryption. This
is used when generating the metadata.

=item B<signing_only>

Indicate that the key for signing is exclusively used for signing and not
encryption and signing.

=item B<cacert>

Path to the CA certificate for verification
Expand Down Expand Up @@ -175,6 +180,8 @@ has 'cert' => (isa => 'Str', is => 'ro', required => 1, predicate => 'has_cert
has 'key' => (isa => 'Str', is => 'ro', required => 1);
has 'cacert' => (isa => 'Str', is => 'rw', required => 0, predicate => 'has_cacert');

has 'signing_only' => (isa => 'Bool', is => 'ro', required => 0);

has 'encryption_key' => (isa => 'Str', is => 'ro', required => 0, predicate => 'has_encryption_key');
has 'error_url' => (isa => Uri, is => 'ro', required => 1, coerce => 1);
has 'org_name' => (isa => 'Str', is => 'ro', required => 1);
Expand Down Expand Up @@ -654,6 +661,8 @@ sub _generate_key_descriptors {

my $key = $use eq 'encryption' ? $self->_encryption_key_text : $self->_cert_text;

$use = 'signing' if $self->signing_only && $use eq 'both';

return $x->KeyDescriptor(
$md,
$use ne 'both' ? { use => $use } : {},
Expand Down
14 changes: 14 additions & 0 deletions t/02-create-sp.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,20 @@ use URN::OASIS::SAML2 qw(:bindings :urn);
}

}

{
my $sp = net_saml2_sp(signing_only => 1);
my $xpath = get_xpath(
$sp->metadata,
md => URN_METADATA,
ds => URN_SIGNATURE,
);


my $kd = get_single_node_ok($xpath, "//md:KeyDescriptor");
is($kd->getAttribute('use'), 'signing', "Key descriptor says sign");
}

{
my $sp = net_saml2_sp( ( encryption_key => 't/sign-nopw-cert.pem' ) );

Expand Down