Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's switch to h2 for sub headings #143

Open
dnmfarrell opened this issue Aug 4, 2018 · 2 comments
Open

Let's switch to h2 for sub headings #143

dnmfarrell opened this issue Aug 4, 2018 · 2 comments
Assignees
Labels
UI: HTML Something's wrong in the HTML

Comments

@dnmfarrell
Copy link
Contributor

In our articles we use h3 as subheaders:

### sub header

Let's switch to H2. It makes more logical sense (if the title is H1), but it will also let us write articles with the nicer underlined sub headings if we want:

sub header
----------

One way to do this would be:

  1. Check if anything is using h2 on the website at the moment, if it is switch it to an alternative
  2. Update our css to style H2 and H3 in exactly the same way, check that they look the same
  3. s/h3/h2/ for all articles.
  4. style H3 like H4 is currently
  5. s/h4/h3/ for all articles
@briandfoy
Copy link
Contributor

If you set up the CSS I'll go through the articles to convert things.

@dnmfarrell dnmfarrell added community: hacktoberfest Good issues for drive-by contributions during Hacktoberfest and removed community: hacktoberfest Good issues for drive-by contributions during Hacktoberfest labels Sep 30, 2018
dnmfarrell pushed a commit that referenced this issue Nov 1, 2018
dnmfarrell pushed a commit that referenced this issue Nov 1, 2018
dnmfarrell pushed a commit that referenced this issue Nov 1, 2018
@dnmfarrell
Copy link
Contributor Author

Ok @briandfoy this is live. This example article uses H2 subheadings. Commit 334901a

@dnmfarrell dnmfarrell removed community: hacktoberfest Good issues for drive-by contributions during Hacktoberfest labels Nov 1, 2018
@briandfoy briandfoy added the UI: HTML Something's wrong in the HTML label Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI: HTML Something's wrong in the HTML
Projects
None yet
Development

No branches or pull requests

2 participants