Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting to work properly with multi-digit version numbers #9

Closed
perlun opened this issue Feb 23, 2017 · 3 comments · Fixed by #18
Closed

Fix sorting to work properly with multi-digit version numbers #9

perlun opened this issue Feb 23, 2017 · 3 comments · Fixed by #18
Labels

Comments

@perlun
Copy link
Owner

perlun commented Feb 23, 2017

Right now, it sorts like this:

## 1.4.0
[Full Changelog](https://github.com/ecraft/blurf/compare/1.3.0...1.4.0)

* 132d945 Merge pull request #83 from ecraft/fix/extract-workerd-method
* c4ffa5e Extract method.

## 1.3.0
[Full Changelog](https://github.com/ecraft/blurf/compare/1.23.0...1.3.0)


## 1.23.0
[Full Changelog](https://github.com/ecraft/blurf/compare/1.22.0...1.23.0)

* 3da262e Attempt to fix 'bundle install' issue on Travis. (#131)
* 727c94b Added foreman, README update
* 1dac76c Make it work in PROD
* 150fb6d Fixed typo

...which is obviously wrong. 1.23.0 is ascii-wise lower than 1.3.0, but not numerically wise.

@perlun perlun added the bug label Feb 23, 2017
@perlun
Copy link
Owner Author

perlun commented May 22, 2017

I looked a bit into this. It's a bit nontrivial since we will need to retain both the potentially v1.4.x and 1.4.y strings (one being a string, the other being a Version instance). That said, it can definitely be fixed, it's just a bit more work.

@perlun
Copy link
Owner Author

perlun commented Nov 15, 2017

This is an annoying bug; it's laughable really. We should fix it.

Workaround for the time being:

$ changelog-rs . 2014.0.12 2014.0.13

@perlun
Copy link
Owner Author

perlun commented Dec 11, 2017

I am being bothered by this again. If someone wants to fix it, I'll be very happy to help you with some details on how it can be sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant