Refactor the runtime settings into a struct #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes more sense than having a lot of parameters. Making this change makes it possible to do a lot of other nice changes, will probably continue doing one of these as soon as I get this reviewed. :)
perlun
force-pushed
the
refactor/move-runtime-settings-to-struct
branch
from
8e3e954 to
e4da106
Compare
mpalmujoki
reviewed
Nov 25, 2016
| to_revision: &'a str | ||
| } | ||
|
|
||
| impl<'a> Settings<'a> { |
There was a problem hiding this comment.
Tried to look up the impl thing, but <'a> Settings<'a> leaves me flustered.
There was a problem hiding this comment.
Understandable. 😄 For reading: Lifetimes in the Rust Book has all the information you are wondering about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes more sense than having a lot of parameters. Making this change makes it possible to do a lot of other nice changes, will probably continue doing one of these as soon as I get this reviewed. :)
/cc @mpalmujoki, can't assign you since you haven't accepted the invite yet.