-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK quickstart structure (done on NodeJS) #373
Conversation
✅ Deploy Preview for permitio-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, please see comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM left some comments. Please address them (let me know if anything needs to be clarified).
After that, please:
- Save a version of the outline in Notion or somewhere we can copy it for next versions
- Make sure to remove all the language placeholders
- Make the quickstart page as the main page of the Node.js SDK
- Remove the
Node.js SDK examples
page and redirect it to here - Add all the existing pages under Node.js in the bottom of the page using the Docusaurus element that shows other sub pages
We still need to think if we want to restructure the other pages under the SDK or keep them as-is.
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
Co-authored-by: Gabriel Manor <g.e.manor@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good progress, left some comments.
Pay attention that you haven't addressed the 3 and 5 points from the previous review.
@gemanor - can you please elaborate points 3 & 5 in more detail - I've addressed them to how I understood them, but it looks like you have something more in mind. For 3 - I replaced the current Node.js quickstart page with the latest quickstart page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice job 👍👏
No description provided.