Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the documentation about the debug mode #394

Merged

Conversation

omer9564
Copy link
Contributor

No description provided.

@omer9564 omer9564 requested review from obsd, danyi1212 and RazcoDev July 29, 2024 09:31
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for permitio-docs ready!

Name Link
🔨 Latest commit 213ad2d
🔍 Latest deploy log https://app.netlify.com/sites/permitio-docs/deploys/66a78d01b67e9300081e38ab
😎 Deploy Preview https://deploy-preview-394--permitio-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@orweis orweis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a tiny note. Otherwise approved

If the debug mode was not changed from unset, it will be treated as activated
:::

:::warning Disadvantages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make the title less negative? E.g. "performance"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Performance Impact

@omer9564 omer9564 merged commit 44cb090 into master Jul 29, 2024
6 checks passed
@omer9564 omer9564 deleted the omer/per-10337-investigate-honeycomb-issue-with-the-new-pdp branch July 29, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants