Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support include total count for listing roles and resources #97

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

teofilomonteiro
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

add the possibility of listing resources with total count

  • What is the current behavior? (You can also link to an open issue here)

no total count is available

  • What is the new behavior (if this is a feature change)?

  • Other information:

This pull request introduces enhancements to the pagination functionality in the API, particularly focusing on extending pagination options to include the total count of items. The changes span across multiple files and involve updates to interfaces, type definitions, and API methods.

Pagination Enhancements:

  • src/api/base.ts: Added IBasePaginationExtended interface to include page, perPage, and includeTotalCount fields. Created IPaginationExtended type to support optional inclusion of total count.

API Resource Changes:

API Role Changes:

Copy link
Contributor

@RazcoDev RazcoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@RazcoDev RazcoDev merged commit 6317248 into permitio:main Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants