fix: LSM cap room bug #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Coverage after merging marc/lsm-cap-fix into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
xlab
approved these changes
Sep 6, 2023
|
Coverage after merging marc/lsm-cap-fix into main
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Overview
This change fixes a bug that happens when a validator is tagged as
delegableafter checking the LSM caps (both validator and bond) but the room left until reaching the cap is less than the amount which is going to be staked by thex/liquidstakeibcmodule the next delegation epoch.This causes the module to generate delegating messages without taking into account that room, and therefore potentially hitting any of the caps and starting an endless loop of delegations.
In order to fix this, after calculating the
delegableflag when receiving an ICQ validator response (and only when that flag istrue), the module will also simulate the generated messages it would create during the next delegation epoch. Then, using the amounts on each of the messages, check if there is enough room to delegate to that validator. If affirmative, the validator keeps tagged asdelegable, and asnon-delegableotherwise.