Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dubious typecast: add Safecast to whitelist #162

Merged
merged 2 commits into from
May 28, 2024
Merged

Dubious typecast: add Safecast to whitelist #162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab34881
added SafeCast to whitelist
Yhtiyar May 27, 2024
cd55ff3
updated docs
Yhtiyar May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions slitherin/detectors/dubious_typecast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ class DubiousTypecast(AbstractDetector):
)
WIKI_RECOMMENDATION = "Use clear constants"

WHITELIST = ["SafeCast", "SignedMath"] # OZ

def analyze_irs(self, irs: List[Operation]) -> List[Tuple[str, str]]:
results = []
for i in irs:
Expand Down Expand Up @@ -98,6 +100,8 @@ def get_dubious_typecasts(self, fun: FunctionContract, params=None):
def _detect(self):
results = []
for contract in self.compilation_unit.contracts_derived:
if contract.name in self.WHITELIST:
continue
for f in contract.functions:
func_res = self.get_dubious_typecasts(f)
if func_res:
Expand Down
Loading