-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Treat Errors As Warnings - ref #2295 #2296
CI Treat Errors As Warnings - ref #2295 #2296
Conversation
…en true, errors will be logged in CI as warnings.
Thanks for looking into this! Will give it a review the next days hopefully. Should the option maybe be a StringOption? Ex. Thoughts on this feature @nohwnd and @ArmaanMcleod? See discussion in related issue |
…evel to account for future compatibility/demands.
CILogLevel is a great idea! I pushed an update that reflects this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! :) Just need to include configuration validation and expand tests.
We should throw a more friendly error when a invalid value is used. Add a check like this just below it. 🙂
Pester/src/functions/Output.ps1
Lines 774 to 776 in d81fdbc
if ($PesterPreference.Output.CIFormat.Value -notin 'None', 'Auto', 'AzureDevops', 'GithubActions') { | |
throw "Unsupported CI format '$($PesterPreference.Output.CIFormat.Value)'" | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Seems this PR didn't make it to the |
Merged, thank you all. Will start preparing next minor release. |
PR Summary
Added parameter 'CITreatErrorsAsWarnings' to output configuration. When true, errors will be logged in CI as warnings.
Fix #2295
PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.