Cleanup about_* help topics and extract PesterConfiguration docs to about_PesterConfiguration #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Should I create a matching PR for v5? V6-docs PR includes the same PesterConfiguration in usage/Configurarion for v5. |
|
Backport bot? :)
Odesláno z aplikace Outlook pro iOS<https://aka.ms/o0ukef>
…________________________________
Od: Frode Flaten ***@***.***>
Odesláno: Monday, July 1, 2024 6:51:04 PM
Komu: pester/Pester ***@***.***>
Kopie: Jakub Jareš ***@***.***>; State change ***@***.***>
Předmět: Re: [pester/Pester] Cleanup about_* help topics and extract PesterConfiguration docs to about_PesterConfiguration (PR #2518)
Nice. Should I create a matching PR for v5?
V6-docs PR includes the same PesterConfiguration in usage/Configurarion for v5.
—
Reply to this email directly, view it on GitHub<#2518 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABLYLYNRYRSXJHNKIWTMXE3ZKGCHRAVCNFSM6AAAAABKEHEFZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBQGYYTQNZRGA>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
|
Yeah, I'll use it as a draft. Need some adjustments to build script + generated docs for v5. 🙂 |
|
/backport to rel/5.6.x |
|
Started backporting to rel/5.6.x: https://github.com/pester/Pester/actions/runs/9748483082 |
|
@fflaten backporting to rel/5.6.x failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Remove outdated docs
Using index info to reconstruct a base tree...
M src/en-US/about_Mocking.help.txt
Falling back to patching base and 3-way merge...
Removing src/en-US/about_TestDrive.help.txt
Removing src/en-US/about_Should.help.txt
CONFLICT (modify/delete): src/en-US/about_Mocking.help.txt deleted in Remove outdated docs and modified in HEAD. Version HEAD of src/en-US/about_Mocking.help.txt left in tree.
Removing src/en-US/about_BeforeEach_AfterEach.help.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Remove outdated docs
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@fflaten an error occurred while backporting to rel/5.6.x, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
|
Guess it's manual cherry pick then 😁 |
fflaten
added a commit
to fflaten/Pester
that referenced
this pull request
Jul 1, 2024
…bout_PesterConfiguration (pester#2518) * Remove outdated docs * Include option types in PesterConfiguration docs * Add draft for about_PesterConfiguration help topic * Move PesterConfiguration options reference to help topic * Minor text updates * wip * Update Invoke-Pester help for Configuration * Update build script * Update help for Invoke-Pester -Configuration * Fix build script * Update about_Pester.help.txt * Update release script
5 tasks
nohwnd
pushed a commit
that referenced
this pull request
Jul 2, 2024
…bout_PesterConfiguration (#2518) (#2522) * Remove outdated docs * Include option types in PesterConfiguration docs * Add draft for about_PesterConfiguration help topic * Move PesterConfiguration options reference to help topic * Minor text updates * wip * Update Invoke-Pester help for Configuration * Update build script * Update help for Invoke-Pester -Configuration * Fix build script * Update about_Pester.help.txt * Update release script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
about_Pesteras a quick introduction pointing the user to the website for full docs.about_PesterConfigurationto simplifyNew-PesterConfigurationhelp and match similar extracted docs on website to Usage\Configuration. See Add v6 preview docs docs#316Fix #2491
Related pester/docs#280 (comment)
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.