Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old and redundant functions #2520

Merged
merged 13 commits into from
Jul 1, 2024
Merged

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented Jun 30, 2024

PR Summary

This is just a suggestion to clean up the codebase. Feel free to reject & close.
This code hasn't been used in v5 lifetime AFAIK and is considered noise.

PR also moves a few helper functions to Pester.Utility as they're shared between files.

This might impact code necessary for #1952, so mentioning it for future reference.

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

src/Pester.Utility.ps1 Fixed Show fixed Hide fixed
src/Pester.Utility.ps1 Fixed Show fixed Hide fixed
Has dependency on SafeCommands which are not available in Utility.
Only used by single P-test, consider inlining in testfile.
@nohwnd nohwnd merged commit 6cefccf into pester:main Jul 1, 2024
11 checks passed
@fflaten fflaten deleted the remove-old-functions branch July 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants