Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CodeCoverage.ExcludeTests #2523

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented Jul 1, 2024

PR Summary

Temporary fix to implement CodeCoverage.ExcludeTests until CodeCoverage configuration parsing either implements old advanced interface or removes the old code and updates tests.

Fix #2514

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@fflaten
Copy link
Collaborator Author

fflaten commented Jul 1, 2024

Backport to 5.6.x patch or will this be considered breaking/feature after never working? Users who never noticed might get a sudden change in coverage report.

@nohwnd
Copy link
Member

nohwnd commented Jul 2, 2024

/backport to /rel/5.6.x

Copy link

github-actions bot commented Jul 2, 2024

Started backporting to /rel/5.6.x: https://github.com/pester/Pester/actions/runs/9758671448

Copy link

github-actions bot commented Jul 2, 2024

@nohwnd an error occurred while backporting to /rel/5.6.x, please check the run log for details!

Error: The specified backport target branch /rel/5.6.x wasn't found in the repo.

src/functions/Coverage.ps1 Outdated Show resolved Hide resolved
@nohwnd nohwnd merged commit b18d7cb into pester:main Jul 2, 2024
1 of 3 checks passed
@nohwnd
Copy link
Member

nohwnd commented Jul 2, 2024

/backport to rel/5.6.x

Copy link

github-actions bot commented Jul 2, 2024

Started backporting to rel/5.6.x: https://github.com/pester/Pester/actions/runs/9758688151

@nohwnd
Copy link
Member

nohwnd commented Jul 2, 2024

Backporting, this is a bug fix, and ExcludeTests = $true is the default, so people who opted in either did not notice or did not care.

@fflaten fflaten deleted the cc-excludetests branch July 2, 2024 09:47
@fflaten fflaten mentioned this pull request Jul 2, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are not included in coverage even when ExcludeTests = $false;
2 participants