-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option for custom Pester module path #111
Conversation
I can build the project locally with |
The latest "main" branch requires Insiders, because the next version of VS Code runs NodeJS 16 and has some breaking changes I had to fix. |
Now I got that "streams" error you talked about so have to wait to practically test this change when that is resolved. |
Main shouldn't have any streams errors, it should test fine. There should be a option to "run extension" in the debug window that will start a new vscode instance running the current version of the extension. |
Ah. That is the way you suppose to do it. 🙂 I document that too. I thought I would document stuff that I was looking for, to help others in the future. 🙂 |
@JustinGrote the debug experience was awesome! Pretty neat how seamless it was. It now works perfectly for both single project workspace and a multi-project workspace. Just need to fix the TODO (loop through workspaces) and the documentation, then I feel pretty great about this change. Do you see anything that could be improved in the code (both style and logic)? |
I'll try to find some time to review tonight, thanks for the contribution! |
@JustinGrote I moved doc changes to another PR. Ready for review now. |
Here is a run with this change. I do not have any Pester module installed in any
It uses the relative path Test run in SqlServerDsc: Note: Those with the yellow symbol that are left are not yet converted, the scripts have a |
Thank you so much for your contribution! I'll try to review again sometime this weekend and hopefully we can get this merged. |
FYI a vsix is automatically built on every commit, you can access it here to start using it right away: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM After Changes
@johlju thanks for your contribution! I'll push a new release after a couple other items I want to get completed. |
@JustinGrote this is my attempt to fix issue #108. Please give pointers if I missed something, I followed how
runTestsInNewProcess
was done to get an idea where to change stuff. 🙂pesterModulePath
Fixes #108
Closes #95