Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo Application #14

Merged
merged 3 commits into from
Jun 18, 2023
Merged

Todo Application #14

merged 3 commits into from
Jun 18, 2023

Conversation

ArchanaRangrej
Copy link
Collaborator

image
image

ShashankSuresh
ShashankSuresh approved these changes Apr 29, 2023
View reviewed changes
Week-11/todo-app/public/logo192.png Outdated Show resolved Hide resolved
Week-11/todo-app/src/App.css Outdated Show resolved Hide resolved
ShashankSuresh
ShashankSuresh suggested changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@ShashankSuresh ShashankSuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see a mix of 2 different use of CSS in this project.

  1. If we are planning to use CSS in JS, please remove all css files.
  2. If we are planning to use .styles.css, then lets stick to that pattern.

Week-12/todo-app/src/components/ActivityList.js Outdated Show resolved Hide resolved
Week-12/todo-app/src/components/ActivityList.js Show resolved Hide resolved
@ArchanaRangrej ArchanaRangrej merged commit 74ebbc3 into master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShashankSuresh ShashankSuresh ShashankSuresh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArchanaRangrej @ShashankSuresh