Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten URL application #15

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Shorten URL application #15

merged 2 commits into from
Jun 18, 2023

Conversation

ArchanaRangrej
Copy link
Collaborator

@ArchanaRangrej ArchanaRangrej commented May 19, 2023 •
edited
Loading

localhost_3001_ (1)

ShashankSuresh
ShashankSuresh suggested changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@ShashankSuresh ShashankSuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a folder to the respective components where the style, test, storybook etc files are housed inside.

Week-13/shortener-url-app/src/components/Content.js Outdated Show resolved Hide resolved
Week-13/shortener-url-app/src/components/Content.js Show resolved Hide resolved
Week-13/shortener-url-app/src/components/Footer.js Show resolved Hide resolved
Week-13/shortener-url-app/src/components/Search.js Outdated Show resolved Hide resolved
Week-13/shortener-url-app/src/components/Search.js Outdated Show resolved Hide resolved
Week-13/shortener-url-app/src/components/Search.js Outdated Show resolved Hide resolved
Week-13/shortener-url-app/src/components/content.css Outdated Show resolved Hide resolved
@ShashankSuresh
Copy link
Collaborator

The UI looks great. Great effort on it. Keep it up :)

@ArchanaRangrej ArchanaRangrej merged commit 20d0c96 into master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShashankSuresh ShashankSuresh ShashankSuresh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArchanaRangrej @ShashankSuresh