Fix an issue where a describe block will prevent a beforeEach call fr…

…om executing
pestphp · Oct 12, 2024 · 0c57142 · 0c57142
1 parent 3f65af9
commit 0c57142
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 6 deletions.
diff --git a/src/PendingCalls/DescribeCall.php b/src/PendingCalls/DescribeCall.php
@@ -15,8 +15,10 @@ final class DescribeCall
 {
     /**
      * The current describe call.
+     *
+     * @var string[]
      */
-    private static ?string $describing = null;
+    private static array $describing = [];
 
     /**
      * The describe "before each" call.
@@ -40,7 +42,7 @@ public function __construct(
      */
     public static function describing(): ?string
     {
-        return self::$describing;
+        return self::$describing[count(self::$describing) - 1] ?? null;
     }
 
     /**
@@ -50,12 +52,12 @@ public function __destruct()
     {
         unset($this->currentBeforeEachCall);
 
-        self::$describing = $this->description;
+        self::$describing[] = $this->description;
 
         try {
             ($this->tests)();
         } finally {
-            self::$describing = null;
+            array_pop(self::$describing);
         }
     }
 

diff --git a/tests/.snapshots/success.txt b/tests/.snapshots/success.txt
@@ -215,6 +215,7 @@
   ✓ depends on describe → bar
   ✓ depends on describe using with → foo with (3)
   ✓ depends on describe using with → bar with (3)
+  ✓ with test after describe → it should run the before each
 
    PASS  Tests\Features\DescriptionLess
   ✓ get 'foo'
@@ -1584,4 +1585,4 @@
    WARN  Tests\Visual\Version
   - visual snapshot of help command output
 
-  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 17 todos, 28 skipped, 1095 passed (2648 assertions)
+  Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 17 todos, 28 skipped, 1096 passed (2649 assertions)
diff --git a/tests/Features/Describe.php b/tests/Features/Describe.php
@@ -96,3 +96,15 @@
         expect($foo + $foo)->toBe(6);
     })->depends('foo');
 })->with([3]);
+
+describe('with test after describe', function () {
+    beforeEach(function () {
+        $this->count++;
+    });
+
+    describe('foo', function () {});
+
+    it('should run the before each', function () {
+        expect($this->count)->toBe(2);
+    });
+});
diff --git a/tests/Visual/Parallel.php b/tests/Visual/Parallel.php
@@ -16,7 +16,7 @@
 
 test('parallel', function () use ($run) {
     expect($run('--exclude-group=integration'))
-        ->toContain('Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 17 todos, 19 skipped, 1085 passed (2624 assertions)')
+        ->toContain('Tests:    2 deprecated, 4 warnings, 5 incomplete, 2 notices, 17 todos, 19 skipped, 1086 passed (2625 assertions)')
         ->toContain('Parallel: 3 processes');
 })->skipOnWindows();