Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Improve coverage output message on failing minimum requirements #1069

Conversation

davybaccaert
Copy link
Contributor

What:

  • Bug Fix
  • New Feature
  • Improvement

Description:

Improves the readability of the console output when the minimum required percentage is not met.
As an added benefit, the value that is most important is at the end of the line, making it easier to spot.

@davybaccaert davybaccaert changed the title Improve coverage output message on failing minimum requirements [2.xImprove coverage output message on failing minimum requirements Jan 20, 2024
@davybaccaert davybaccaert changed the title [2.xImprove coverage output message on failing minimum requirements [2.x] Improve coverage output message on failing minimum requirements Jan 20, 2024
Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes more sense grammatically, at least to me. 👀

Note: Not sure if this requires any changes to tests.

@nunomaduro nunomaduro merged commit 0060b6f into pestphp:2.x Jan 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants