fix: updates Only plugin to check for CI environment #1082
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Pest v1 had a
--ci
flag that could be used in CI environments to ignore->only()
calls that were accidentally checked-in to the code base.This feature looks to have been removed around the release of Pest v2 but it is unlear if it was an intentional choice or simply an omission as a result of a refactor to the
->only()
feature. The commit that disabled the feature makes no mention of that intent and remnants of the--ci
feature remain in the code base (such as theEnvironment
plugin).This PR restores the functionality of the
--ci
flag by updating theOnly
plugin to check theEnvironment
plugin when it is invoked.Related:
pest/src/Plugins/Environment.php
Line 35 in 13f340a