Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kth_distance in query #62

Closed
wants to merge 1 commit into from
Closed

Use kth_distance in query #62

wants to merge 1 commit into from

Conversation

azizkayumov
Copy link

This PR modifies query to use current distance to kth neighbor to early prune unnecessary node visits.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #62 (13dd4b6) into main (dad5656) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   77.91%   77.81%   -0.10%     
==========================================
  Files           3        3              
  Lines         335      338       +3     
==========================================
+ Hits          261      263       +2     
- Misses         74       75       +1     
Impacted Files Coverage Δ
src/ball_tree.rs 77.68% <100.00%> (-0.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azizkayumov
Copy link
Author

@msk is it related to this PR? From the benchmarks, Ball-Tree (in its current form) is always worse than the brute force (even in low dimensions), having kth_distance checked, Ball-Tree performs better in lower dimensions.

@azizkayumov
Copy link
Author

Closing as obsolete, opened an issue for future readers #63.

@azizkayumov azizkayumov deleted the knn_query branch June 23, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant