Multi journal config feature implementation #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arkatufus is this already implemented or does this still need to be merged? |
Arkatufus
changed the title
…ence.Azure into Multi_journal_POC
Aaronontheweb
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
LGTM - @Arkatufus can you do a separate PR to cleanup the copyright headers on the code sample?
| // <copyright file="ShardRegionKey.cs" company="Akka.NET Project"> | ||
| // Copyright (C) 2013-2023 .NET Foundation <https://github.com/akkadotnet/akka.net> | ||
| // </copyright> | ||
| // ----------------------------------------------------------------------- |
There was a problem hiding this comment.
No DNF headers here - this is a Petabridge project
|
|
||
| builder.AddSetup(setup); | ||
| builder.AddSetup(multiSetup); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi journal configuration feature based on discussion in akkadotnet/Akka.Hosting#142
AzureTableStorageMultiJournalSetupandAzureBlobMultiSnapshotSetupclass are wrapper classes that contains a dictionary that maps journal/snapshot config id with their respective setup classes.Setupclass are applied on to the respective journal/snapshot settings twice, once for the "global"Setupclass and then with the individual per IDSetupclasses, if any were found.Option classes are added for Azure journal and snapshot, the
AzureTableStorageJournalOptionsclass allows user to setup multiple journal with different journal identifiers so that it can be used by other plugins that can utilize specific journal ids