remove json call in remix module-resolution test (cloudflare#109)

petebacondarwin · Dec 11, 2024 · 36efad1 · 36efad1
1 parent 755bb4b
commit 36efad1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/playground/module-resolution/__tests__/module-resolution.spec.ts b/playground/module-resolution/__tests__/module-resolution.spec.ts
@@ -87,16 +87,11 @@ describe('module resolution', async () => {
 			});
 		});
 
-		// Note: this test is skipped during build because the remix import does not work in preview
-		//       because there seem to be an I/O operation being performed at the top level of the
-		//       generated remix bundled module, this is a legitimate issue and a workerd known quirk/bug
-		//       (https://github.com/flarelabs-net/vite-plugin-cloudflare/issues/83)
-		test.skipIf(isBuild)('@remix-run/cloudflare', async () => {
+		test('@remix-run/cloudflare', async () => {
 			const result = await getJsonResponse('/third-party/remix');
 			expect(result).toEqual({
 				'(remix) remixRunCloudflareCookieName':
 					'my-remix-run-cloudflare-cookie',
-				'(remix) typeof cloudflare json({})': 'object',
 			});
 		});
 

diff --git a/playground/module-resolution/src/third-party/remix.ts b/playground/module-resolution/src/third-party/remix.ts
@@ -1,7 +1,6 @@
-import { createCookie, json } from '@remix-run/cloudflare';
+import { createCookie } from '@remix-run/cloudflare';
 
 export default {
-	'(remix) typeof cloudflare json({})': typeof json({}),
 	'(remix) remixRunCloudflareCookieName': createCookie(
 		'my-remix-run-cloudflare-cookie',
 	).name,