-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update action runtime to node 20 #2340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you. I'm planning to do this in the next major version. |
Could this be considered for merging? Node 16 is unsupported since 11 Sep 2023 and has been removed from some distributions. |
peter-evans
pushed a commit
that referenced
this pull request
Oct 9, 2023
* feat: update action runtime to node 20 * ci: run with node v20, matching action manifest
peter-evans
pushed a commit
that referenced
this pull request
Oct 9, 2023
* feat: update action runtime to node 20 * ci: run with node v20, matching action manifest
I've added this feature to the v6 release candidate. You can use it like this: - uses: peter-evans/create-pull-request@v6-rc I'll be releasing @ericcornelissen Thank you for contributing! |
peter-evans
pushed a commit
that referenced
this pull request
Nov 30, 2023
* feat: update action runtime to node 20 * ci: run with node v20, matching action manifest
peter-evans
added a commit
that referenced
this pull request
Nov 30, 2023
peter-evans
added a commit
that referenced
this pull request
Dec 19, 2023
peter-evans
added a commit
that referenced
this pull request
Dec 27, 2023
peter-evans
added a commit
that referenced
this pull request
Jan 31, 2024
peter-evans
added a commit
that referenced
this pull request
Jan 31, 2024
* feat: update author and committer input defaults * Update github-actions[bot] * Update author to new email format * feat: optional input for git ops token * feat: allow push-to-fork to push to sibling repos (#2414) Fixes #2412. * build: update dist * feat: update action runtime to node 20 (#2340) * feat: add truncate warning to pull request body * perf: unshallow only when necessary * fix: remove the remote for the fork on completion * feat: infer github server and api urls * test: integration test fixes * build: bump major version * docs: update to v6 --------- Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com> Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
peter-evans
added a commit
that referenced
this pull request
Jan 31, 2024
* feat: update author and committer input defaults * Update github-actions[bot] * Update author to new email format * feat: optional input for git ops token * feat: allow push-to-fork to push to sibling repos (#2414) Fixes #2412. * build: update dist * feat: update action runtime to node 20 (#2340) * feat: add truncate warning to pull request body * perf: unshallow only when necessary * fix: remove the remote for the fork on completion * feat: infer github server and api urls * test: integration test fixes * build: bump major version * docs: update to v6 --------- Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com> Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
aleksandrychev
pushed a commit
to aleksandrychev/create-pull-request
that referenced
this pull request
Mar 4, 2024
* feat: update author and committer input defaults * Update github-actions[bot] * Update author to new email format * feat: optional input for git ops token * feat: allow push-to-fork to push to sibling repos (peter-evans#2414) Fixes peter-evans#2412. * build: update dist * feat: update action runtime to node 20 (peter-evans#2340) * feat: add truncate warning to pull request body * perf: unshallow only when necessary * fix: remove the remote for the fork on completion * feat: infer github server and api urls * test: integration test fixes * build: bump major version * docs: update to v6 --------- Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com> Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1074 but this time upgrading the Node.js runtime from v16 to v20. Note that Node.js v16 will be end of life on 11 Sep 2023, so GitHub will probably deprecate it around that time for Actions as well.
It might make sense to combine this upgrade with a bump from
actions/checkout@v3
toactions/checkout@v4
because it also bumped the Node.js runtime from v16 to v20. Other actions (relevant:peter-evans/create-or-update-project-card
,actions/setup-node
,actions/upload-artifact
,actions/download-artifact
,peter-evans/find-comment
,peter-evans/create-or-update-comment
,peter-evans/slash-command-dispatch
,actions/setup-java
1,peter-evans/repository-dispatch
) used/mentioned here do not seem be upgraded yet, except fortibdex/github-app-token@v2
andcrazy-max/ghaction-import-gpg@v6
(as of writing).Footnotes
this one is listed as
@v2
currently while the latest release as of writing is v3. ↩