Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action runtime to node 20 #2340

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Update action runtime to node 20 #2340

merged 2 commits into from
Oct 9, 2023

Conversation

ericcornelissen
Copy link

@ericcornelissen ericcornelissen commented Sep 12, 2023

Similar to #1074 but this time upgrading the Node.js runtime from v16 to v20. Note that Node.js v16 will be end of life on 11 Sep 2023, so GitHub will probably deprecate it around that time for Actions as well.

It might make sense to combine this upgrade with a bump from actions/checkout@v3 to actions/checkout@v4 because it also bumped the Node.js runtime from v16 to v20. Other actions (relevant: peter-evans/create-or-update-project-card, actions/setup-node, actions/upload-artifact, actions/download-artifact, peter-evans/find-comment, peter-evans/create-or-update-comment, peter-evans/slash-command-dispatch, actions/setup-java1, peter-evans/repository-dispatch) used/mentioned here do not seem be upgraded yet, except for tibdex/github-app-token@v2 and crazy-max/ghaction-import-gpg@v6 (as of writing).

Footnotes

  1. this one is listed as @v2 currently while the latest release as of writing is v3.

@ericcornelissen ericcornelissen marked this pull request as ready for review September 12, 2023 16:10
@peter-evans
Copy link
Owner

Thank you. I'm planning to do this in the next major version.

@j2ghz
Copy link

j2ghz commented Oct 7, 2023

Could this be considered for merging? Node 16 is unsupported since 11 Sep 2023 and has been removed from some distributions.

@peter-evans peter-evans changed the base branch from main to node20 October 9, 2023 10:28
@peter-evans peter-evans merged commit 39832cb into peter-evans:node20 Oct 9, 2023
peter-evans pushed a commit that referenced this pull request Oct 9, 2023
* feat: update action runtime to node 20

* ci: run with node v20, matching action manifest
peter-evans pushed a commit that referenced this pull request Oct 9, 2023
* feat: update action runtime to node 20

* ci: run with node v20, matching action manifest
@peter-evans
Copy link
Owner

I've added this feature to the v6 release candidate. You can use it like this:

      - uses: peter-evans/create-pull-request@v6-rc

I'll be releasing v6 at some point in the near future.

@ericcornelissen Thank you for contributing!

@ericcornelissen ericcornelissen deleted the patch-1 branch October 9, 2023 11:12
peter-evans pushed a commit that referenced this pull request Nov 30, 2023
* feat: update action runtime to node 20

* ci: run with node v20, matching action manifest
peter-evans added a commit that referenced this pull request Jan 31, 2024
* feat: update author and committer input defaults

* Update github-actions[bot]

* Update author to new email format

* feat: optional input for git ops token

* feat: allow push-to-fork to push to sibling repos (#2414)

Fixes #2412.

* build: update dist

* feat: update action runtime to node 20 (#2340)

* feat: add truncate warning to pull request body

* perf: unshallow only when necessary

* fix: remove the remote for the fork on completion

* feat: infer github server and api urls

* test: integration test fixes

* build: bump major version

* docs: update to v6

---------

Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
peter-evans added a commit that referenced this pull request Jan 31, 2024
* feat: update author and committer input defaults

* Update github-actions[bot]

* Update author to new email format

* feat: optional input for git ops token

* feat: allow push-to-fork to push to sibling repos (#2414)

Fixes #2412.

* build: update dist

* feat: update action runtime to node 20 (#2340)

* feat: add truncate warning to pull request body

* perf: unshallow only when necessary

* fix: remove the remote for the fork on completion

* feat: infer github server and api urls

* test: integration test fixes

* build: bump major version

* docs: update to v6

---------

Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
aleksandrychev pushed a commit to aleksandrychev/create-pull-request that referenced this pull request Mar 4, 2024
* feat: update author and committer input defaults

* Update github-actions[bot]

* Update author to new email format

* feat: optional input for git ops token

* feat: allow push-to-fork to push to sibling repos (peter-evans#2414)

Fixes peter-evans#2412.

* build: update dist

* feat: update action runtime to node 20 (peter-evans#2340)

* feat: add truncate warning to pull request body

* perf: unshallow only when necessary

* fix: remove the remote for the fork on completion

* feat: infer github server and api urls

* test: integration test fixes

* build: bump major version

* docs: update to v6

---------

Co-authored-by: Teko <112829523+Teko012@users.noreply.github.com>
Co-authored-by: Benjamin Gilbert <bgilbert@backtick.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants