CBOR serializer (using cbor2 package) #191
Conversation
| queue.put({"foo": 1, "bar": 2}) | ||
| self.assertEqual(queue.total, 1) | ||
| queue.put({"bar": 2, "foo": 1}) | ||
| self.assertEqual(queue.total, 1) |
There was a problem hiding this comment.
Better to verify the content in the queue as well
There was a problem hiding this comment.
None of the other tests (pickle, msgpack, json) verify the content in the queue. I presume this is because this particular test is testing that duplicate items are only queued once for UniqueQ. I also presume that verifiying the content is handled in test_queue.py
There was a problem hiding this comment.
You're right, we have more test to cover serialization scenario for file based queues, maybe we can enhance the coverage next time for sqlite base queues
|
@brendan-simon-indt looks fine, please address the comment in code and pep8 issue in CI
|
| queue.put({"foo": 1, "bar": 2}) | ||
| self.assertEqual(queue.total, 1) | ||
| queue.put({"bar": 2, "foo": 1}) | ||
| self.assertEqual(queue.total, 1) |
There was a problem hiding this comment.
You're right, we have more test to cover serialization scenario for file based queues, maybe we can enhance the coverage next time for sqlite base queues
Add CBOR serializer support, using the
cbor2package.CBOR protocol is similar to
msgpack, however CBOR has a cleaner design, is standardized and preferred overmsgpackby some.I modelled the implementation based on the
msgpackimplementation.I arbitrarily chose
cbor25.2.0 has the minimum version requirement, as this was the first release to make it into a Debian distribution as a pre-built package (Debian 11 Bullseye). It is likely that earliercbor2versions would also work.