Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor DiffRowGenerator, code cleanup #16

Merged
merged 2 commits into from
Dec 19, 2021

Conversation

petertrr
Copy link
Owner

  • Get rid of builder in favor of constructor
  • Code cleanup, docs cleanup

BREAKING: API of DiffRowGenerator has changed, constructor should be used instead of builder

* Get rid of builder in favor of constructor
* Code cleanup, docs cleanup

BREAKING: API of DiffRowGenerator has changed, constructor should be used instead of builder
@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #16 (e460393) into main (dce5b9e) will decrease coverage by 0.24%.
The diff coverage is 88.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #16      +/-   ##
============================================
- Coverage     83.01%   82.76%   -0.25%     
- Complexity       99      101       +2     
============================================
  Files            12       12              
  Lines           518      470      -48     
  Branches         91       85       -6     
============================================
- Hits            430      389      -41     
+ Misses           63       57       -6     
+ Partials         25       24       -1     
Flag Coverage Δ
unittests 82.76% <88.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/kotlin/io/github/petertrr/diffutils/DiffUtils.kt 78.12% <0.00%> (ø)
...kotlin/io/github/petertrr/diffutils/patch/Chunk.kt 66.66% <ø> (ø)
...ub/petertrr/diffutils/algorithm/myers/MyersDiff.kt 89.83% <77.77%> (ø)
...kotlin/io/github/petertrr/diffutils/patch/Patch.kt 81.25% <100.00%> (ø)
...github/petertrr/diffutils/text/DiffRowGenerator.kt 92.68% <100.00%> (+2.16%) ⬆️
...n/io/github/petertrr/diffutils/text/StringUtils.kt 69.23% <0.00%> (-7.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dce5b9e...e460393. Read the comment docs.

@petertrr petertrr merged commit dc2b266 into main Dec 19, 2021
@petertrr petertrr deleted the feature/diff-row-generator-cleanup branch December 19, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant