Skip to content

Commit

Permalink
Block Bindings: Remove key fallback in bindings get values and rely o…
Browse files Browse the repository at this point in the history
…n source label (#65517)

* Always fall back to source label

* Adapt e2e tests

Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

Source: WordPress/gutenberg@4baca3e
  • Loading branch information
SantosGuillamot committed Sep 20, 2024
1 parent 2f03d41 commit 9da6ff3
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions build/block-editor/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -42576,8 +42576,8 @@ const withBlockBindingSupport = (0,external_wp_compose_namespaceObject.createHig
let values = {};
if (!source.getValues) {
Object.keys(bindings).forEach(attr => {
// Default to the `key` or the source label when `getValues` doesn't exist
values[attr] = bindings[attr].args?.key || source.label;
// Default to the the source label when `getValues` doesn't exist.
values[attr] = source.label;
});
} else {
values = source.getValues({
Expand Down
2 changes: 1 addition & 1 deletion build/block-editor/index.min.asset.php
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('react', 'react-dom', 'react-jsx-runtime', 'wp-a11y', 'wp-api-fetch', 'wp-blob', 'wp-block-serialization-default-parser', 'wp-blocks', 'wp-commands', 'wp-components', 'wp-compose', 'wp-data', 'wp-date', 'wp-deprecated', 'wp-dom', 'wp-element', 'wp-hooks', 'wp-html-entities', 'wp-i18n', 'wp-is-shallow-equal', 'wp-keyboard-shortcuts', 'wp-keycodes', 'wp-notices', 'wp-polyfill', 'wp-preferences', 'wp-primitives', 'wp-private-apis', 'wp-rich-text', 'wp-style-engine', 'wp-token-list', 'wp-url', 'wp-warning', 'wp-wordcount'), 'version' => '954f072fbc62a788c0fb');
<?php return array('dependencies' => array('react', 'react-dom', 'react-jsx-runtime', 'wp-a11y', 'wp-api-fetch', 'wp-blob', 'wp-block-serialization-default-parser', 'wp-blocks', 'wp-commands', 'wp-components', 'wp-compose', 'wp-data', 'wp-date', 'wp-deprecated', 'wp-dom', 'wp-element', 'wp-hooks', 'wp-html-entities', 'wp-i18n', 'wp-is-shallow-equal', 'wp-keyboard-shortcuts', 'wp-keycodes', 'wp-notices', 'wp-polyfill', 'wp-preferences', 'wp-primitives', 'wp-private-apis', 'wp-rich-text', 'wp-style-engine', 'wp-token-list', 'wp-url', 'wp-warning', 'wp-wordcount'), 'version' => '616e86c19a40788abfdf');
2 changes: 1 addition & 1 deletion build/block-editor/index.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/block-editor/index.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion gutenberg.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

### BEGIN AUTO-GENERATED DEFINES
define( 'GUTENBERG_VERSION', '19.3.0' );
define( 'GUTENBERG_GIT_COMMIT', '0237d6eb4faec08c5f2cf8849fb5c38d6b7b8d67' );
define( 'GUTENBERG_GIT_COMMIT', '4baca3e1730c748936c26864aad39b9cc0b51e3c' );
### END AUTO-GENERATED DEFINES
defined( 'GUTENBERG_MINIMUM_WP_VERSION' ) or define( 'GUTENBERG_MINIMUM_WP_VERSION', '6.5' );

Expand Down

0 comments on commit 9da6ff3

Please sign in to comment.