chore(sdk): depend on protobuf 4 in kfp and kfp-kubernetes (kubef…

…low#10307)
petethegreat · Mar 27, 2024 · 0e8a2d4 · 0e8a2d4
1 parent d3645c1
commit 0e8a2d4
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/kubernetes_platform/python/setup.py b/kubernetes_platform/python/setup.py
@@ -19,9 +19,9 @@
 
 NAME = 'kfp-kubernetes'
 REQUIREMENTS = [
-    'protobuf>=3.13.0,<4',
-    # bump version when platform-specific compilation is released and tests no longer install kfp from source
-    'kfp>=2.0.0-beta.13',
+    'protobuf>=4.21.1,<5',
+    # TODO: bump to 2.6.0 after next KFP SDK release with protobuf 4
+    'kfp>=2.5.0',
 ]
 DEV_REQUIREMENTS = [
     'docformatter==1.4',

diff --git a/sdk/RELEASE.md b/sdk/RELEASE.md
@@ -3,6 +3,7 @@
 ## Features
 
 ## Breaking changes
+* Soft breaking change for [Protobuf 3 EOL](https://protobuf.dev/support/version-support/#python). Migrate to `protobuf==4`. Drop support for `protobuf==3`. [\#10307](https://github.com/kubeflow/pipelines/pull/10307)
 
 ## Deprecations
 

diff --git a/sdk/python/requirements.in b/sdk/python/requirements.in
@@ -11,14 +11,14 @@ google-auth>=1.6.1,<3
 # https://github.com/googleapis/python-storage/blob/main/CHANGELOG.md#221-2022-03-15
 google-cloud-storage>=2.2.1,<3
 # pin kfp-pipeline-spec to an exact version, since this is the contract between a given KFP SDK version and the BE. we don't want old version of the SDK to write new fields and to have the BE reject the new unsupported field (even if the new field backward compatible from a proto perspective)
-kfp-pipeline-spec==0.2.2
+kfp-pipeline-spec==0.3.0
 # Update the upper version whenever a new major version of the
 # kfp-server-api package is released.
 # Update the lower version when kfp sdk depends on new apis/fields in
 # kfp-server-api.
 kfp-server-api>=2.0.0,<2.1.0
 kubernetes>=8.0.0,<27
-protobuf>=3.13.0,<4
+protobuf>=4.21.1,<5
 PyYAML>=5.3,<7
 requests-toolbelt>=0.8.0,<1
 tabulate>=0.8.6,<1

diff --git a/sdk/python/requirements.txt b/sdk/python/requirements.txt
@@ -41,15 +41,15 @@ googleapis-common-protos==1.56.4
     # via google-api-core
 idna==3.3
     # via requests
-kfp-pipeline-spec==0.2.2
+kfp-pipeline-spec==0.3.0
     # via -r requirements.in
-kfp-server-api==2.0.0-rc.1
+kfp-server-api==2.0.5
     # via -r requirements.in
 kubernetes==23.6.0
     # via -r requirements.in
 oauthlib==3.2.0
     # via requests-oauthlib
-protobuf==3.20.1
+protobuf==4.25.1
     # via
     #   -r requirements.in
     #   google-api-core