Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow_dispatch to publish-release github action to allow manua… #596

Closed
wants to merge 1 commit into from
Closed

Add workflow_dispatch to publish-release github action to allow manua… #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: release
on:
release:
types: [published]
workflow_dispatch:
Copy link
Member

@juarezr juarezr Feb 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • What if there is a corrupted package already?
  • It will work for conda-forge also?
  • I didn't find the issue in conda-forge CD yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Complementing my previous comments
  • It would be amazing to have such functionality
  • How does it work?
    • Can I select the commit or the version?
    • It's possible to overwrite a corrupted version also?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried this yet to be honest. I'll try to give it a go on test.pypi.org from my branch and update you with the outcome

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Neither I have explored it yet.
  • I haven't tried before because:
    • It was the first time the release pipeline was broken.
    • It looks like it matter most using the time somewhere else
    • I didn't have the PyPI/feedstock admin access

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturponinski,

I think I figured out how to use workflow_dispatch for triggering actions.

Basically:

  1. Setup workflow_dispatch with up to 10 input tags / entries.
  2. React in the workflow steps according to the inputs and event type
  3. Github Actions will show a trigger button when this is set up accordingly.


jobs:
pypi:
Expand Down