Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Final cleanup #13

Merged

Conversation

peytondmurray
Copy link
Owner

Why are these changes needed?

This PR removes tune-sklearn as a dependency (it's no longer needed to build docs in master). This was pulling in a lot of transitive dependencies (including ray!), and a few needed to be mocked out to make the docs build.

Related issue number

Partially addresses ray-project#37944.
Targets ray-project#41115.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray peytondmurray force-pushed the docs-build-system-upgrade-cleanup branch from 74e965f to ed76f5c Compare November 18, 2023 16:42
@peytondmurray peytondmurray merged this pull request into docs-build-system-upgrade Nov 18, 2023
1 check passed
@peytondmurray peytondmurray deleted the docs-build-system-upgrade-cleanup branch November 18, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant