-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure compound classes to use JAR plugins first #294
Comments
The first plugin format supported by PF4J was ZIP. In order to not affect the applications that already use this format (old PF4J version) for plugins, and to increase the adoption of the new PF4J versions, I made the decision to support this format out of the box (no modifications required). |
I see, thanks! Such change is breaking for applications using both formats and relying on CompondX to pick the right format. But just to be clear: I do not propose to drop support of ZIP; rather to check for JAR in CompoundX managers first because JAR is the default format. |
Thanks for clarification. I think that is a good idea. A PR is welcome. |
I made the modifications on a new (feature) branch. I was forced to adapt a test to fix a fail. This test fail can be a problem for people, so I will investigate why the test failed:
|
As documentation states that the JAR plugin format is recommended and shall be used by default, shan't the compound description finder, loader, and repository be configured with JAR versions first? It will (can't say how much) improve performance and reduce the number of log messages in the common case.
The text was updated successfully, but these errors were encountered: