Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client-side URl validation #421

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Client-side URl validation #421

merged 2 commits into from
Sep 27, 2023

Conversation

edent
Copy link
Contributor

@edent edent commented Sep 26, 2023

Fixes #420

@pfefferle
Copy link
Owner

Isn't type="url" already testing for a valid URL?

@pfefferle
Copy link
Owner

Ah, read your issue afterwards ☺️

pfefferle
pfefferle approved these changes Sep 27, 2023
View reviewed changes
Copy link
Owner

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pfefferle pfefferle merged commit 2b17e82 into pfefferle:main Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfefferle pfefferle pfefferle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "required" attribute for HTML form - and some validation?
2 participants
@edent @pfefferle