-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a settings page to allow someone with manage_options permission to define static content URIs #1
base: master
Are you sure you want to change the base?
Conversation
- verify correct behavior with WP latest (4.6.1) - add Settings page to set up to three well-known URIs
- use `esc_textarea` going out and `wp_filter_post_kses` coming back - add some more documentation
I like the idea, but I think supporting only three URIs is enough. We should support n-URIs and perhaps add a field for the mime type. |
@pfefferle - mission accomplished. |
@pfefferle - any thing else or is it ready for a merge? thanks! |
+1 /mtr On Sat, Oct 22, 2016 at 11:31 AM -0700, "Matthias Pfefferle" notifications@github.com wrote: I like the idea, but I don't think supporting only three types is enough. We should support n-URIs and perhaps add a field for the mime type. — |
Thanks a lot for your work! Here is some feedback:
|
…and do not escape URI contents field
thanks. i have addressed the first two issues. a custom post type would probably work, but then we are into a whole set of admin page edits. my goal was to solve the problem for folks who want to populate their site with a single well-known URI without having to do any PHP programming. i think we've got that handled along with a lot of other things. could we merge this PR and get it onto wordpress.org so i can point folks to it? thanks! |
@pfefferle - sorry to nag, but "i'm on deadline"... can we get the PR merged and onto wordpress.org ? thanks! |
## Generic function (and/or define) names
should have caught these earlier…
update: hi! i submitted the forked repo to wordpress.org, it's available as https://wordpress.org/plugins/well-known-uris/ ... if you merge this PR, i can retract that plugin and point people at this one. sorry for the confusion! best, /mtr |
for non-programmers, requiring an edit to the plugin source to define the URIs and their contents is probably too much friction. for well-known URIs that have static content, the Setting page is sufficient...
also, tested the plugin on WP latest (4.6.1)
i hope you like this addition, thanks!