Skip to content

Commit

Permalink
Merge pull request #115 from keisukefukuda/fix-generate-exp-id
Browse files Browse the repository at this point in the history
Add parameter to generate_exp_id()
  • Loading branch information
muupan authored Dec 17, 2020
2 parents 51c0127 + b2f46c0 commit 62a26ca
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pfrl/experiments/prepare_output_dir.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def is_under_git_control():
return pfrl.utils.is_return_code_zero(["git", "rev-parse"])


def generate_exp_id(prefix=None) -> str:
def generate_exp_id(prefix=None, argv=sys.argv) -> str:
"""Generate reproducible, unique and deterministic experiment id
The generated id will be string generated from prefix, Git
Expand All @@ -39,7 +39,7 @@ def generate_exp_id(prefix=None) -> str:
names.append(head.decode())

# Caveat: does not work with new files that are not yet cached
sources = [subprocess.check_output("git diff HEAD".split()), pickle.dumps(sys.argv)]
sources = [subprocess.check_output("git diff HEAD".split()), pickle.dumps(argv)]

for source in sources:
names.append("%08x" % crc32(source))
Expand Down

0 comments on commit 62a26ca

Please sign in to comment.