Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter to generate_exp_id() #115

Merged
merged 1 commit into from
Dec 17, 2020
+2 −2
Merged

Add parameter to generate_exp_id() #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pfrl/experiments/prepare_output_dir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def is_under_git_control():
return pfrl.utils.is_return_code_zero(["git", "rev-parse"])


def generate_exp_id(prefix=None) -> str:
def generate_exp_id(prefix=None, argv=sys.argv) -> str:
"""Generate reproducible, unique and deterministic experiment id
The generated id will be string generated from prefix, Git
Expand All @@ -39,7 +39,7 @@ def generate_exp_id(prefix=None) -> str:
names.append(head.decode())

# Caveat: does not work with new files that are not yet cached
sources = [subprocess.check_output("git diff HEAD".split()), pickle.dumps(sys.argv)]
sources = [subprocess.check_output("git diff HEAD".split()), pickle.dumps(argv)]

for source in sources:
names.append("%08x" % crc32(source))
Expand Down