Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove six dependency in pre-trained models #148

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Conversation

ummavi
Copy link
Member

@ummavi ummavi commented Jun 9, 2021

Addresses #147

@ummavi
Copy link
Member Author

ummavi commented Jun 9, 2021

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 451117b:

@github-actions github-actions bot requested a review from marioyc June 9, 2021 04:31
@marioyc
Copy link
Contributor

marioyc commented Jun 9, 2021

Could you check the lint error?

Make import style consistent and apply isort
@ummavi
Copy link
Member Author

ummavi commented Jun 9, 2021

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 0f5b899:

@ummavi
Copy link
Member Author

ummavi commented Jun 9, 2021

Looks like I had an older version of isort that disagrees with the CI. Sorry for all the triggers!
/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 864aa3c:

Copy link
Contributor

@marioyc marioyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@marioyc marioyc merged commit e113a88 into master Jun 9, 2021
@marioyc marioyc deleted the ummavi-patch-1 branch June 9, 2021 08:16
@muupan muupan added this to the v0.3.0 milestone Jul 7, 2021
@muupan muupan added the enhancement New feature or request label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants