Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] use functools.partial instead of lambda #157

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

zhouzypaul
Copy link

so there's no lazy execution issue when assigning env seeds

@github-actions github-actions bot requested a review from ummavi September 5, 2021 20:00
@zhouzypaul
Copy link
Author

see issue #156

@muupan
Copy link
Member

muupan commented Sep 7, 2021

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit f8a561a:

@muupan
Copy link
Member

muupan commented Sep 7, 2021

Thanks for your PR! Now it looks fine (compared with #156 (comment)):

python examples/atari/train_ppo_ale.py --gpu -1
Output files are saved in results/f8a561ae627d31138ac6fe975e06bfbfe20ee345-1c0dd107-67bc6343
make_env called with idx: 0
make_env called with idx: 1
make_env called with idx: 2
make_env called with idx: 3
make_env called with idx: 4
make_env called with idx: 5
make_env called with idx: 6
make_env called with idx: 7
Observation space Box(4, 84, 84)
Action space Discrete(4)
make_env called with idx: 0
make_env called with idx: 1
make_env called with idx: 2
make_env called with idx: 3
make_env called with idx: 4
make_env called with idx: 5
make_env called with idx: 6
make_env called with idx: 7
make_env called with idx: 0
make_env called with idx: 1
make_env called with idx: 2
make_env called with idx: 3
make_env called with idx: 4
make_env called with idx: 5
make_env called with idx: 6
make_env called with idx: 7

@muupan muupan removed the request for review from ummavi September 7, 2021 11:38
@muupan
Copy link
Member

muupan commented Sep 7, 2021

pfrl/tests/wrappers_tests/test_monitor.py failed in pfn-public-ci/pfrl.cpu, but this must be unrelated (#158) to the PR so I'll merge.

@muupan muupan merged commit 8782485 into pfnet:master Sep 7, 2021
@muupan muupan added this to the v0.4.0 milestone Jul 16, 2023
@muupan muupan added bug Something isn't working example Modification or addition of examples labels Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working example Modification or addition of examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants