Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError in pad_sequence for torch>=1.9.0 #163

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Fix TypeError in pad_sequence for torch>=1.9.0 #163

merged 2 commits into from
Mar 14, 2022

Conversation

muupan
Copy link
Member

@muupan muupan commented Jan 16, 2022

Hopefully resolves #154

@muupan
Copy link
Member Author

muupan commented Jan 16, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit fda5361:

@muupan muupan mentioned this pull request Jan 16, 2022
Closed
keisuke-nakata
keisuke-nakata approved these changes Jan 16, 2022
View reviewed changes
Copy link
Member

@keisuke-nakata keisuke-nakata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I have no idea why tests are broken though

@muupan
Copy link
Member Author

muupan commented Mar 14, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 5350f84:

@muupan muupan changed the title [WIP] Fix TypeError in pad_sequence for torch>=1.9.0 Fix TypeError in pad_sequence for torch>=1.9.0 Mar 14, 2022
@muupan
Copy link
Member Author

muupan commented Mar 14, 2022

Now that CI is all successful I'm merging it.

@muupan muupan merged commit d89ddf6 into pfnet:master Mar 14, 2022
@muupan muupan deleted the fix-pad-sequence-error branch March 14, 2022 08:29
@muupan muupan added this to the v0.4.0 milestone Jul 16, 2023
@muupan muupan added the enhancement New feature or request label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keisuke-nakata keisuke-nakata keisuke-nakata approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

recurrent examples fails with "TypeError: pad_sequence(): sequences must be tuple of Tensors, not Tensor"
3 participants
@muupan @pfn-ci-bot @keisuke-nakata