Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASSERT [tftpDynamicCommand] /home/vagrant/rpi4-uefi/Build/RPi4/DEBUG_GCC5/AARCH64/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand/DEBUG/AutoGen.c(520): !EFI_ERROR (Status) #38

Closed
andreiw opened this issue Apr 16, 2020 · 2 comments
Closed

ASSERT [tftpDynamicCommand] /home/vagrant/rpi4-uefi/Build/RPi4/DEBUG_GCC5/AARCH64/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand/DEBUG/AutoGen.c(520): !EFI_ERROR (Status) #38

andreiw opened this issue Apr 16, 2020 · 2 comments
Assignees
@samerhaj
Labels
bug Something isn't working fixed-v1.9 Issue known to be fixed in v1.9 and subsequent releases v1.7 Issue known to exist in v1.7 v1.8 Issue known to exist in v1.8

Comments

@andreiw
Copy link
Member

andreiw commented Apr 16, 2020

Also tracked on Pi 3 as pftf/RPi3#11
@andreiw andreiw added the bug Something isn't working label Apr 16, 2020
@andreiw
Copy link
Member Author

andreiw commented Apr 16, 2020

`Here's what's around line 520 in AutoGen.c:

VOID
EFIAPI
ProcessLibraryConstructorList (
IN EFI_HANDLE ImageHandle,
IN EFI_SYSTEM_TABLE *SystemTable
)
{
EFI_STATUS Status;

Status = BaseDebugLibSerialPortConstructor ();
ASSERT_RETURN_ERROR (Status);

Status = UefiBootServicesTableLibConstructor (ImageHandle, SystemTable);
ASSERT_EFI_ERROR (Status);

Status = UefiRuntimeServicesTableLibConstructor (ImageHandle, SystemTable);
ASSERT_EFI_ERROR (Status);

Status = UefiHiiServicesLibConstructor (ImageHandle, SystemTable);
ASSERT_EFI_ERROR (Status);

Status = UefiLibConstructor (ImageHandle, SystemTable);
ASSERT_EFI_ERROR (Status);

Status = ShellLibConstructor (ImageHandle, SystemTable);
ASSERT_EFI_ERROR (Status); // line 520

}

So obviously the result from the call to ShellLibConstructor() was unexpected.`

@andreiw andreiw added v1.8 Issue known to exist in v1.8 v1.7 Issue known to exist in v1.7 bug Something isn't working and removed bug Something isn't working labels Apr 16, 2020
samerhaj added a commit to samerhaj/edk2-platforms that referenced this issue Apr 19, 2020
@samerhaj
Platform/RaspberryPi/RPi4: Fix TFTP dynamic command initialization
1c35a28 
Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command.
This fixes an ASSERT observed in pftf/RPi4#38

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Pete Batard <pete@akeo.ie>
Cc: Andrei Warkentin <awarkentin@vmware.com>
Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
@samerhaj samerhaj self-assigned this Apr 19, 2020
ardbiesheuvel pushed a commit to tianocore/edk2-platforms that referenced this issue Apr 20, 2020
@samerhaj
Platform/RaspberryPi/RPi4: Fix TFTP dynamic command initialization
f09ea1a 
Set the PcdShellLibAutoInitialize for the TFTP dynamic Shell command.
This fixes an ASSERT observed in pftf/RPi4#38

Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
@pbatard
Copy link
Member

pbatard commented Apr 21, 2020

Should be fixed with latest build.

@pbatard pbatard closed this as completed Apr 21, 2020
@andreiw andreiw added the fixed-v1.9 Issue known to be fixed in v1.9 and subsequent releases label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samerhaj samerhaj

Labels
bug Something isn't working fixed-v1.9 Issue known to be fixed in v1.9 and subsequent releases v1.7 Issue known to exist in v1.7 v1.8 Issue known to exist in v1.8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andreiw @pbatard @samerhaj