-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing CGAL #1188
Merged
Merged
Removing CGAL #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/common/coordinates_input.c modified: src/common/delauny_input.c modified: src/common/edges_input.c modified: src/common/matrixRows_input.c modified: src/common/orders_input.c modified: src/common/pgr_point_input.c modified: src/common/points_input.c modified: src/common/restrictions_input.c
modified: include/contraction/pgr_contractionGraph.hpp modified: include/cpp_common/basePath_SSEC.hpp modified: include/dijkstra/pgr_dijkstra.hpp modified: include/mst/pgr_mst.hpp modified: include/mst/pgr_prim.hpp modified: src/allpairs/johnson_driver.cpp modified: src/components/articulationPoints_driver.cpp modified: src/components/biconnectedComponents_driver.cpp modified: src/components/bridges_driver.cpp modified: src/components/connectedComponents_driver.cpp modified: src/components/strongComponents_driver.cpp modified: src/contraction/contractGraph_driver.cpp modified: src/lineGraph/lineGraphFull_driver.cpp modified: src/lineGraph/lineGraph_driver.cpp modified: src/mincut/stoerWagner_driver.cpp modified: src/mst/randomSpanningTree_driver.cpp modified: src/pickDeliver/pickDeliverEuclidean_driver.cpp
modified: include/cpp_common/pgr_base_graph.hpp modified: include/yen/pgr_ksp.hpp modified: src/common/edges_input.c modified: src/common/vehicles_input.c modified: src/trsp/GraphDefinition.cpp modified: src/trsp/pgr_trspHandler.cpp modified: src/trsp/trsp.c
modified: include/max_flow/pgr_maxflow.hpp
modified: include/astar/pgr_astar.hpp modified: include/cpp_common/basePath_SSEC.hpp modified: include/cpp_common/basic_vertex.h modified: include/dagShortestPath/pgr_dagShortestPath.hpp modified: include/dijkstra/pgr_dijkstra.hpp modified: include/dijkstra/pgr_dijkstraVia.hpp modified: include/tsp/pgr_tsp.hpp modified: src/common/basic_vertex.cpp modified: src/contraction/contractGraph_driver.cpp modified: src/ksp/turnRestrictedPath_driver.cpp
modified: include/cpp_common/basePath_SSEC.hpp modified: include/cpp_common/pgr_bidirectional.hpp modified: include/lineGraph/pgr_lineGraphFull.hpp modified: include/yen/pgr_ksp.hpp modified: include/yen/pgr_turnRestrictedPath.hpp
modified: include/max_flow/pgr_maxflow.hpp
@cayetanobv this PR I think is ready for merge, how can we work it out:
|
@cvvergara when you merge this PR I will merge this: pgRouting/docker-pgrouting#9 |
cayetanobv
approved these changes
Mar 5, 2019
marsam
added a commit
to r-ryantm/nixpkgs
that referenced
this pull request
May 23, 2020
These dependencies were removed in pgRouting/pgrouting#1188
cvvergara
added a commit
to cvvergara/pgrouting
that referenced
this pull request
Aug 26, 2021
Removing CGAL
lbartoletti
added a commit
to lbartoletti/cgal-web
that referenced
this pull request
May 17, 2023
pgRouting no longer uses CGAL since pgRouting/pgrouting#1188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes CGAL, GMP and MTFR dependencies.
For that purpose, the underlying code for the alpha shape algorithm had to be written to fulfill pgrouting way of using CGAL's alphashape.
Note that an alpha shape consists on a collection of polygons, lines and points, but pgRouting has being using only the polygons. So the algorithm implemented in this PR ignores lines and points that are part of an alpha shape, just as the lines and points were ignored from CGAL results.
The pgr_alphaShape is useless by itself (its the "core" function), unless its being used using pgr_pointsAsPolygons which converts the output of pgr_alphaShape to polygon geometries.
The implementation this PR is proposing:
r
<spoon radius
.(https://github.com/cvvergara/pgrouting/blob/a4f91e45311b5df760ed3fa887610384b4dcae78/tools/testers/alphaShapeTester.sql#L49)
S
shapeTODO
Keep in mind that pgRouting focus is not on geometries, so once PostGIS has an alpha shape function, say
ST_AlphaShape
, that returns a geometry collection of polygons lines and points, then this "specialization" will be just a wrapper of such a function that extracts the polygon part.Give an appropriate name to this function
pgr_alphaShape:
ST_AlphaShape
pgr_pointsAsPolygons:
Move to legacy pgr_alphaShape & pgr_pointsAsPolygons
Documentation
@pgRouting/admins