Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory should not rely on folder being part of a git repository (against main) #2470

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Directory should not rely on folder being part of a git repository (against main) #2470

merged 1 commit into from
Feb 6, 2023

Conversation

robe2
Copy link
Member

@robe2 robe2 commented Feb 4, 2023

Fixes #2452

Changes proposed in this pull request:

  • The recent change to setup_db.sh assumed testing will be done against a git repository.
  • In the case of self-hosted runner, this is not the case
  • I suspect many packagers will also not be testing against a git repository, and may be using a tar ball instead. As such relying on this folder being part of a git repo will fail for them.

Note that this fix is a subset of #2469. Those additional changes I don't think are needed to make it work for CentOS so don't need to be backported to main.

@pgRouting/admins

@robe2 robe2 requested a review from cvvergara February 6, 2023 19:45
@cvvergara cvvergara added this to the Release 3.5.0 milestone Feb 6, 2023
@cvvergara cvvergara added the CI Conitnuous Integration label Feb 6, 2023
@robe2 robe2 merged commit 88d68c9 into pgRouting:main Feb 6, 2023
cvvergara pushed a commit to cvvergara/pgrouting that referenced this pull request Feb 21, 2023
@robe2 robe2 deleted the do-not-assume-git branch October 23, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Conitnuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to test Centos 7
2 participants