Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dijkstra] Removing duplicated code #2512

Merged
merged 4 commits into from
May 15, 2023
Merged

[dijkstra] Removing duplicated code #2512

merged 4 commits into from
May 15, 2023

Conversation

cvvergara
Copy link
Member

Changes proposed in this pull request:

  • Removing duplicated code due to the combinations query
  • Updating release notes with missing notes

@pgRouting/admins

@cvvergara cvvergara added this to the Release 3.6.0 milestone May 10, 2023
@cvvergara cvvergara marked this pull request as draft May 10, 2023 14:45
@cvvergara cvvergara force-pushed the simplify-dijkstra-code-try1 branch from b4bdcbc to 66c3a4b Compare May 10, 2023 15:01
@cvvergara cvvergara force-pushed the simplify-dijkstra-code-try1 branch from d8b8d16 to 377472a Compare May 10, 2023 15:05
@cvvergara cvvergara marked this pull request as ready for review May 10, 2023 15:11
@cvvergara cvvergara marked this pull request as draft May 10, 2023 15:14
@cvvergara cvvergara force-pushed the simplify-dijkstra-code-try1 branch from 67a993e to 7ff6cbe Compare May 12, 2023 23:38
@cvvergara cvvergara marked this pull request as ready for review May 12, 2023 23:52
krashish8
krashish8 approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@krashish8 krashish8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

shobhit162
shobhit162 approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@shobhit162 shobhit162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@cvvergara cvvergara merged commit b320711 into pgRouting:develop May 15, 2023
@cvvergara cvvergara deleted the simplify-dijkstra-code-try1 branch September 20, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shobhit162 shobhit162 shobhit162 approved these changes

@krashish8 krashish8 krashish8 approved these changes

@dkastl dkastl Awaiting requested review from dkastl

@robe2 robe2 Awaiting requested review from robe2

@cayetanobv cayetanobv Awaiting requested review from cayetanobv

@omshinde omshinde Awaiting requested review from omshinde

Assignees
No one assigned
Labels
C/C++ Dijkstra
Projects
None yet
Milestone
Release 3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cvvergara @krashish8 @shobhit162