Not use wildcards on sql

NEWS

@@ -16,6 +16,11 @@ Changes on the documentation to the following:
 
   * using bootstrap_version 2 because 3+ does not do dropdowns
 
+**SQL enhancements**
+
+* [#2561](https://github.com/pgRouting/pgrouting/issues/2561) Not use
+  wildcards on SQL
+
 **pgtap tests**
 
 * [#2559](https://github.com/pgRouting/pgrouting/issues/2559) pgtap test using sampledata

doc/src/release_notes.rst

@@ -38,6 +38,11 @@ Changes on the documentation to the following:
 
   * using bootstrap_version 2 because 3+ does not do dropdowns
 
+.. rubric:: SQL enhancements
+
+* `#2561 <https://github.com/pgRouting/pgrouting/issues/2561>`__ Not use
+  wildcards on SQL
+
 .. rubric:: pgtap tests
 
 * `#2559 <https://github.com/pgRouting/pgrouting/issues/2559>`__ pgtap test using sampledata

docqueries/src/migration.result

@@ -557,7 +557,7 @@ SELECT * FROM pgr_maxCardinalityMatch(
   $$SELECT id, source, target, cost AS going, reverse_cost AS coming FROM edges$$,
   directed => true
 );
-WARNING:  pgr_maxCardinalityMatch(text,boolean) deprecated on v3.4.0
+WARNING:  pgr_maxCardinalityMatch(text,boolean) deprecated signature on v3.4.0
  seq | edge | source | target
 -----+------+--------+--------
    1 |    1 |      5 |      6

sql/allpairs/floydWarshall.sql

@@ -39,7 +39,7 @@ CREATE FUNCTION pgr_floydWarshall(
 RETURNS SETOF RECORD AS
 $BODY$
 
-    SELECT *
+    SELECT start_vid, end_vid, agg_cost
     FROM _pgr_floydWarshall(_pgr_get_statement($1), $2);
 
 $BODY$

sql/allpairs/johnson.sql

@@ -39,7 +39,7 @@ CREATE FUNCTION pgr_johnson(
 RETURNS SETOF RECORD AS
 $BODY$
 
-    SELECT *
+    SELECT start_vid, end_vid, agg_cost
     FROM _pgr_johnson(_pgr_get_statement($1), $2);
 
 $BODY$

sql/astar/astar.sql

@@ -140,8 +140,8 @@ CREATE FUNCTION pgr_aStar(
 
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
-    FROM _pgr_aStar(_pgr_get_statement($1), $2::BIGINT[],  $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT) AS a;
+    SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
+    FROM _pgr_aStar(_pgr_get_statement($1), $2::BIGINT[],  $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
 COST 100
@@ -169,8 +169,8 @@ CREATE FUNCTION pgr_aStar(
 
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
-    FROM _pgr_aStar(_pgr_get_statement($1), _pgr_get_statement($2), $3, $4, $5::FLOAT, $6::FLOAT) AS a;
+    SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
+    FROM _pgr_aStar(_pgr_get_statement($1), _pgr_get_statement($2), $3, $4, $5::FLOAT, $6::FLOAT);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
 COST 100

sql/bdAstar/bdAstar.sql

@@ -48,8 +48,8 @@ CREATE FUNCTION pgr_bdAstar(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT a.seq, a.path_seq, a.node, a.edge, a.cost, a.agg_cost
-    FROM _pgr_bdAstar(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], ARRAY[$3]::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false) AS a;
+    SELECT seq, path_seq, node, edge, cost, agg_cost
+    FROM _pgr_bdAstar(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], ARRAY[$3]::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
 COST 100
@@ -76,8 +76,8 @@ CREATE FUNCTION pgr_bdAstar(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT a.seq, a.path_seq, a.end_vid, a.node, a.edge, a.cost, a.agg_cost
-    FROM _pgr_bdAstar(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false) AS a;
+    SELECT seq, path_seq, end_vid, node, edge, cost, agg_cost
+    FROM _pgr_bdAstar(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
 COST 100
@@ -104,8 +104,8 @@ CREATE FUNCTION pgr_bdAstar(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT a.seq, a.path_seq, a.start_vid, a.node, a.edge, a.cost, a.agg_cost
-    FROM _pgr_bdAstar(_pgr_get_statement($1), $2::BIGINT[], ARRAY[$3]::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false) AS a;
+    SELECT seq, path_seq, start_vid, node, edge, cost, agg_cost
+    FROM _pgr_bdAstar(_pgr_get_statement($1), $2::BIGINT[], ARRAY[$3]::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
 COST 100
@@ -133,7 +133,7 @@ CREATE FUNCTION pgr_bdAstar(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
+    SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
     FROM _pgr_bdAstar(_pgr_get_statement($1), $2::BIGINT[], $3::BIGINT[], $4, $5, $6::FLOAT, $7::FLOAT, false);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
@@ -161,7 +161,7 @@ CREATE FUNCTION pgr_bdAstar(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
+    SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
     FROM _pgr_bdAstar(_pgr_get_statement($1), _pgr_get_statement($2), $3, $4, $5::FLOAT, $6::FLOAT, false);
 $BODY$
 LANGUAGE sql VOLATILE STRICT

sql/bdDijkstra/bdDijkstra.sql

@@ -47,8 +47,8 @@ CREATE FUNCTION pgr_bdDijkstra(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT a.seq, a.path_seq, a.node, a.edge, a.cost, a.agg_cost
-    FROM _pgr_bdDijkstra(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], ARRAY[$3]::BIGINT[], $4, false) AS a;
+    SELECT seq, path_seq, node, edge, cost, agg_cost
+    FROM _pgr_bdDijkstra(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], ARRAY[$3]::BIGINT[], $4, false);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
 COST 100
@@ -73,8 +73,8 @@ CREATE FUNCTION pgr_bdDijkstra(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT a.seq, a.path_seq, a.end_vid, a.node, a.edge, a.cost, a.agg_cost
-    FROM _pgr_bdDijkstra(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], $3::BIGINT[], $4, false) as a;
+    SELECT seq, path_seq, end_vid, node, edge, cost, agg_cost
+    FROM _pgr_bdDijkstra(_pgr_get_statement($1), ARRAY[$2]::BIGINT[], $3::BIGINT[], $4, false);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
 COST 100
@@ -99,8 +99,8 @@ CREATE FUNCTION pgr_bdDijkstra(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT a.seq, a.path_seq, a.start_vid, a.node, a.edge, a.cost, a.agg_cost
-    FROM _pgr_bdDijkstra(_pgr_get_statement($1), $2::BIGINT[], ARRAY[$3]::BIGINT[], $4, false) as a;
+    SELECT seq, path_seq, start_vid, node, edge, cost, agg_cost
+    FROM _pgr_bdDijkstra(_pgr_get_statement($1), $2::BIGINT[], ARRAY[$3]::BIGINT[], $4, false);
 $BODY$
 LANGUAGE sql VOLATILE STRICT
 COST 100
@@ -127,8 +127,8 @@ CREATE FUNCTION pgr_bdDijkstra(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
-    FROM _pgr_bdDijkstra(_pgr_get_statement($1), $2::BIGINT[], $3::BIGINT[], directed, false) as a;
+    SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
+    FROM _pgr_bdDijkstra(_pgr_get_statement($1), $2::BIGINT[], $3::BIGINT[], directed, false);
 $BODY$
 LANGUAGE SQL VOLATILE STRICT
 COST 100
@@ -153,8 +153,8 @@ CREATE FUNCTION pgr_bdDijkstra(
     OUT agg_cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
-    FROM _pgr_bdDijkstra(_pgr_get_statement($1), _pgr_get_statement($2), directed, false) as a;
+    SELECT seq, path_seq, start_vid, end_vid, node, edge, cost, agg_cost
+    FROM _pgr_bdDijkstra(_pgr_get_statement($1), _pgr_get_statement($2), directed, false);
 $BODY$
 LANGUAGE SQL VOLATILE STRICT
 COST 100

sql/breadthFirstSearch/breadthFirstSearch.sql

@@ -58,7 +58,7 @@ BEGIN
 
 
     RETURN QUERY
-    SELECT *
+    SELECT a.seq, a.depth, a.start_vid, a.node, a.edge, a.cost, a.agg_cost
     FROM _pgr_breadthFirstSearch(_pgr_get_statement($1),  ARRAY[$2]::BIGINT[], max_depth, directed) AS a;
 END;
 $BODY$
@@ -92,7 +92,7 @@ BEGIN
 
 
     RETURN QUERY
-    SELECT *
+    SELECT a.seq, a.depth, a.start_vid, a.node, a.edge, a.cost, a.agg_cost
     FROM _pgr_breadthFirstSearch(_pgr_get_statement($1), $2::BIGINT[], max_depth, directed) AS a;
 END;
 $BODY$
@@ -107,7 +107,7 @@ IS 'pgr_breadthFirstSearch(One to Depth)
 - Parameters:
   - edges SQL with columns: id, source, target, cost [,reverse_cost]
   - From vertex identifier
-- Optional Parameters: 
+- Optional Parameters:
   - Maximum Depth := 9223372036854775807
   - directed := true
 - Documentation:
@@ -125,4 +125,4 @@ IS 'pgr_breadthFirstSearch(Many to Depth)
   - directed := true
 - Documentation:
   - ${PROJECT_DOC_LINK}/pgr_breadthFirstSearch.html
-';
+';

sql/chinese/pgr_chinesePostman.sql

@@ -46,7 +46,7 @@ CREATE FUNCTION pgr_chinesePostman(
 
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
+    SELECT seq, node, edge, cost, agg_cost
     FROM _pgr_chinesePostman(_pgr_get_statement($1), only_cost := false);
 $BODY$
 LANGUAGE SQL VOLATILE STRICT;

sql/circuits/hawickCircuits.sql

@@ -48,8 +48,8 @@ RETURNS SETOF RECORD AS
 $BODY$
 BEGIN
     RETURN QUERY
-    SELECT *
-    FROM _pgr_hawickCircuits(_pgr_get_statement($1));
+    SELECT a.seq, a.path_id, a.path_seq, a.start_vid, a.end_vid, a.node, a.edge, a.cost, a.agg_cost
+    FROM _pgr_hawickCircuits(_pgr_get_statement($1)) AS a;
 END;
 $BODY$
 LANGUAGE plpgsql VOLATILE STRICT;

sql/coloring/bipartite.sql

@@ -40,7 +40,7 @@ RETURNS SETOF RECORD AS
 $BODY$
 BEGIN
     RETURN QUERY
-    SELECT *
+    SELECT node, color
     FROM _pgr_bipartite(_pgr_get_statement($1));
 END;
 $BODY$

sql/coloring/edgeColoring.sql

@@ -40,8 +40,8 @@ RETURNS SETOF RECORD AS
 $BODY$
 BEGIN
     RETURN QUERY
-    SELECT *
-    FROM _pgr_edgeColoring(_pgr_get_statement($1));
+    SELECT a.edge_id, a.color_id
+    FROM _pgr_edgeColoring(_pgr_get_statement($1)) AS a;
 END;
 $BODY$
 LANGUAGE plpgsql VOLATILE STRICT;

sql/coloring/sequentialVertexColoring.sql

@@ -42,8 +42,8 @@ RETURNS SETOF RECORD AS
 $BODY$
 BEGIN
     RETURN QUERY
-    SELECT *
-    FROM _pgr_sequentialVertexColoring(_pgr_get_statement($1));
+    SELECT a.vertex_id, a.color_id
+    FROM _pgr_sequentialVertexColoring(_pgr_get_statement($1)) AS a;
 END;
 $BODY$
 LANGUAGE plpgsql VOLATILE STRICT;

sql/common/_checkcolumn.sql

@@ -92,4 +92,4 @@ LANGUAGE plpgsql VOLATILE STRICT;
 
 -- COMMENTS
 COMMENT ON FUNCTION _pgr_checkColumn(TEXT, TEXT, TEXT, BOOLEAN, BOOLEAN)
-IS '_pgr_checkColumn is an internal function';
+IS 'pgRouting internal function';

sql/common/_checkquery.sql

@@ -65,4 +65,4 @@ LANGUAGE plpgsql VOLATILE STRICT;
 
 -- COMMENTS
 COMMENT ON FUNCTION _pgr_checkquery(TEXT)
-IS '_pgr_checkquery is an internal function';
+IS 'pgrouting internal function';

sql/common/pgrouting_utilities.sql

@@ -198,11 +198,11 @@ DECLARE
     naming record;
     err boolean;
 BEGIN
-    select * into naming from _pgr_getTableName(tab,reportErrs, fnName) ;
+    select a.sname, a.tname into naming from _pgr_getTableName(tab,reportErrs, fnName) AS a;
     sname=naming.sname;
     tname=naming.tname;
 
-    select * into cname from _pgr_getColumnName(sname,tname,col,reportErrs, fnName);
+    select _pgr_getColumnName into cname from _pgr_getColumnName(sname,tname,col,reportErrs, fnName);
     RETURN cname;
 END;
 
@@ -239,7 +239,7 @@ $BODY$
 DECLARE
     cname text;
 BEGIN
-    select * from _pgr_getColumnName(tab,col,0, '_pgr_isColumnInTable') into cname;
+    select _pgr_getColumnName from _pgr_getColumnName(tab,col,0, '_pgr_isColumnInTable') into cname;
     return cname is not null;
 END;
 $BODY$
@@ -342,17 +342,17 @@ DECLARE
     pkey text;
     value boolean;
 BEGIN
-    SELECT * into naming FROM _pgr_getTableName(tab, 0, fnName);
+    SELECT a.sname, a.tname into naming FROM _pgr_getTableName(tab, 0, fnName) AS a;
     sname=naming.sname;
     tname=naming.tname;
     IF sname IS NULL OR tname IS NULL THEN
         RETURN FALSE;
     END IF;
-    SELECT * into cname from _pgr_getColumnName(sname, tname, col, 0, fnName) ;
+    SELECT _pgr_getColumnName into cname from _pgr_getColumnName(sname, tname, col, 0, fnName) ;
     IF cname IS NULL THEN
         RETURN FALSE;
     END IF;
-    select * into value  from _pgr_isColumnIndexed(sname, tname, cname, reportErrs, fnName);
+    select _pgr_isColumnIndexed into value  from _pgr_isColumnIndexed(sname, tname, cname, reportErrs, fnName);
     return value;
 END
 $BODY$

sql/common/utilities_pgr.sql

@@ -187,8 +187,8 @@ BEGIN
     select * into naming from _pgr_getTableName(tab,reportErrs, fnName) ;
     sname=naming.sname;
     tname=naming.tname;
-    select * into cname from _pgr_getColumnName(tab,col,reportErrs, fnName) ;
-    select * into ctype from _pgr_getColumnType(sname,tname,cname,reportErrs, fnName);
+    select _pgr_getColumnName into cname from _pgr_getColumnName(tab,col,reportErrs, fnName) ;
+    select _pgr_getColumnType into ctype from _pgr_getColumnType(sname,tname,cname,reportErrs, fnName);
     RETURN ctype;
 END;
 

sql/components/biconnectedComponents.sql

@@ -36,8 +36,8 @@ CREATE FUNCTION pgr_biconnectedComponents(
     OUT edge BIGINT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
-    FROM _pgr_biconnectedComponents(_pgr_get_statement($1));
+    SELECT seq, component, edge
+    FROM _pgr_biconnectedComponents(_pgr_get_statement($1)) ;
 $BODY$
 LANGUAGE SQL VOLATILE STRICT;
 

sql/components/connectedComponents.sql

@@ -46,7 +46,7 @@ CREATE FUNCTION pgr_connectedComponents(
     OUT node BIGINT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
+    SELECT seq, component, node
     FROM _pgr_connectedComponents(_pgr_get_statement($1));
 $BODY$
 LANGUAGE SQL VOLATILE STRICT;

sql/components/makeConnected.sql

@@ -39,8 +39,8 @@ CREATE FUNCTION pgr_makeConnected(
 
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
-    FROM _pgr_makeConnected(_pgr_get_statement($1)) AS a;
+    SELECT seq, start_vid, end_vid
+    FROM _pgr_makeConnected(_pgr_get_statement($1));
 $BODY$
 LANGUAGE SQL VOLATILE STRICT;
 

sql/components/strongComponents.sql

@@ -36,7 +36,7 @@ CREATE FUNCTION pgr_strongComponents(
     OUT node BIGINT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
+    SELECT seq, component, node
     FROM _pgr_strongComponents(_pgr_get_statement($1));
 $BODY$
 LANGUAGE SQL VOLATILE STRICT;

sql/contraction/contraction.sql

@@ -55,7 +55,7 @@ CREATE FUNCTION pgr_contraction(
     OUT cost FLOAT)
 RETURNS SETOF RECORD AS
 $BODY$
-    SELECT *
+    SELECT type, id, contracted_vertices, source, target, cost
     FROM _pgr_contraction(_pgr_get_statement($1), $2::BIGINT[],  $3, $4, $5);
 $BODY$
 LANGUAGE SQL VOLATILE STRICT;