Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(C++)(lint) adding mising includes after code checkr works #2613

Merged
merged 2 commits into from
Feb 11, 2024
Merged

(C++)(lint) adding mising includes after code checkr works #2613

merged 2 commits into from
Feb 11, 2024

Conversation

cvvergara
Copy link
Member

@cvvergara cvvergara commented Feb 8, 2024 •
edited
Loading

Maybe Fixes #2612

Changes proposed in this pull request:

  • Fixed code checker marks missing includes
    • added the missing includes
  • @sanak to test the branch

@pgRouting/admins

@cvvergara cvvergara added this to the Release 3.7.0 milestone Feb 8, 2024
@cvvergara cvvergara requested a review from sanak February 8, 2024 18:00
@cvvergara
Copy link
Member Author

Will merge this one
The CI build for MacOS is passing
https://github.com/pgRouting/pgrouting/actions/runs/7833971583/job/21376196495?pr=2613

@cvvergara cvvergara merged commit 7a65a1c into pgRouting:develop Feb 11, 2024
19 checks passed
@cvvergara cvvergara deleted the fixing-includes-from-code-checker branch February 11, 2024 19:30
@sanak
Copy link
Member

sanak commented Feb 13, 2024 •
edited
Loading

@cvvergara Sorry, I missed this.
I will check on my local M1 Mac environment, later.
=> I encountered the same issue with #2607 (comment), so I will create a new issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanak sanak Awaiting requested review from sanak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cvvergara @sanak