Add additional test for PL/pgSQL parsing #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlinsley
commented
Oct 26, 2023
| "typname": "UNKNOWN" | ||
| } | ||
| }, | ||
| "refname": "input" |
There was a problem hiding this comment.
It's surprising that it couldn't find the data type for input, since it's clearly listed in the function arguments.
There was a problem hiding this comment.
I think that might be a limitation of the libpg_query logic here - we could investigate and see if we can fix that, if helpful.
There was a problem hiding this comment.
It's not strictly needed for what we're looking at internally; it was just surprising.
lfittl
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of this PR is to show that
parse_plpgsqlcan be used to extract query text from a function.