Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPY no longer blows up, but... #111

Closed
benchub opened this issue Oct 16, 2018 · 4 comments · Fixed by #112
Closed

COPY no longer blows up, but... #111

benchub opened this issue Oct 16, 2018 · 4 comments · Fixed by #112

Comments

@benchub
Copy link

benchub commented Oct 16, 2018

print PgQuery.parse("COPY (SELECT 1 from foo) TO STDOUT").deparse

returns just

COPY TO STDOUT

That seems suboptimal.

@lfittl
Copy link
Member

lfittl commented Oct 17, 2018

@benchub Yup, thats not good :)

Either you or @herwinw interested in making a patch?

I believe all thats needed is to call deparse on the query variable and insert that when needed.

@benchub
Copy link
Author

benchub commented Oct 17, 2018 via email

@herwinw
Copy link
Contributor

herwinw commented Oct 18, 2018

Maybe next week

@herwinw
Copy link
Contributor

herwinw commented Oct 18, 2018

I guess this is not the only location where some functionality in deparse is missing, so more cases like this are likely to appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants