Correctly find nested tables in a subselect in a join condition #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tassosb
commented
Nov 9, 2021
lib/pg_query/parse.rb
Outdated
| end | ||
| end | ||
|
|
||
| subselect_items.concat(join_expr_quals) |
There was a problem hiding this comment.
This seems to work, but I'd appreciate someone more familiar with the code taking a look. It's possible I may be overlooking something.
lfittl
approved these changes
Nov 12, 2021
lfittl
reviewed
Nov 12, 2021
| @@ -273,6 +273,7 @@ def load_objects! # rubocop:disable Metrics/CyclomaticComplexity | |||
| when :join_expr | |||
| from_clause_items << { item: next_item[:item].join_expr.larg, type: next_item[:type] } | |||
| from_clause_items << { item: next_item[:item].join_expr.rarg, type: next_item[:type] } | |||
| subselect_items.concat << next_item[:item].join_expr.quals | |||
There was a problem hiding this comment.
Oh, I just realized we are missing a .to_ary here (because of https://bugs.ruby-lang.org/issues/18140, per the comment on top of the function) -- I'll make a quick commit to adjust that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior:
On
main,bazisn't being found. On my branch it is, as well as tables that are nested further inside of a join condition (see spec for a query with more nested join conditions and subqueries).