Find function calls referenced in expression indexes #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msakrejda
commented
Apr 13, 2022
lfittl
approved these changes
Apr 13, 2022
spec/lib/parse_spec.rb
Outdated
| expect(query.warnings).to eq [] | ||
| expect(query.tables).to eq ['test'] | ||
| expect(query.ddl_tables).to eq ['test'] | ||
| expect(query.call_functions).to eq ['lower'] |
There was a problem hiding this comment.
I wonder if its also worth checking filter_columns here? (just to have that be deterministic, I'm actually not sure if it'd return an empty table with a column name for regular elements, or no columns at all?)
There was a problem hiding this comment.
I added filter_columns to the spec and added support for that. Is that what you meant? Maybe it's just my unfamiliarity with pg_query, but I don't quite follow your comment.
seanlinsley
reviewed
Apr 13, 2022
seanlinsley
reviewed
Apr 13, 2022
seanlinsley
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a brand new test instead of modifying the existing CREATE
INDEX test; I can merge these if that makes more sense.