Expose recursive walk functionality via walk!
#268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
This exposes the private
treewalker!
via awalk!
interface. I opted to create a newwalk!
instead of makingtreewalk!
public to avoid changing the signature on treewalker -- I could have made the tree argument have a default, but 🤷 I went this way. Happy to change it.I added a note to the README, though I'm a bit on the fence. In favor, documenting this seems good for the next person. But, I think my table rename example might be too trivial. In my own testing (see #267) I needed something that feels much larger than belongs there. If it's a common enough need, it could be pulled into the library directly, but that feels like a deeper feature to consider.
In contrast, this is a pretty small patch.
Anyhow, that's a long winded explanation.